mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhou xing <xingz...@cn.ibm.com>
Subject Re: Review Request 50184: Fixed length argument bug when reading file.
Date Wed, 20 Jul 2016 02:23:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50184/
-----------------------------------------------------------

(Updated July 20, 2016, 2:23 a.m.)


Review request for mesos and Anand Mazumdar.


Changes
-------

indent modifications


Bugs: mesos-5867
    https://issues.apache.org/jira/browse/mesos-5867


Repository: mesos


Description
-------

If length provided by client is bigger than
(size - offset), the data returned by read
file API should only contain the data actually
read from the file. Now, a length long string
will be returned which may contain blank characters.


Diffs (updated)
-----

  src/files/files.cpp 8ab8f8aad9cfe1e536b29e8994fcd8599627e590 
  src/tests/api_tests.cpp d20b999f3a0d833d67c21fa267413b94277909dd 

Diff: https://reviews.apache.org/r/50184/diff/


Testing
-------

make
make check

run mesos-master with --log_dir or --external_log_file specified. 
Open a browser and goto 127.0.0.1:5050, click 'LOG' link on the home page.
The log of master shall be shown and updated correctly.


Thanks,

zhou xing


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message