mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.
Date Mon, 18 Jul 2016 22:30:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50003/#review142588
-----------------------------------------------------------




src/local/flags.hpp (lines 33 - 37)
<https://reviews.apache.org/r/50003/#comment208208>

    s/work_dir/`work_dir`/
    s/ in local//
    
    Perhaps something like:
    Since local mode is used strictly for non-production purposes, it is the one case where
we deem it acceptable to use a default value for the `work_dir`. We add the `work_dir` flag
here to specify the default and then pass the flag's value along to the master/agent flags.



src/local/local.cpp (line 171)
<https://reviews.apache.org/r/50003/#comment208209>

    s/work_dir/`work_dir`/



src/tests/test_framework_test.sh (line 24)
<https://reviews.apache.org/r/50003/#comment208276>

    I see what you mean about the failure of these `atexit` statements - I also see lots of
litter in my /tmp directory, and in fact, this TestFramework test was failing for me due to
leftover agent metadata in `/tmp/mesos/local`.
    
    Before modifying this test in this way, I'd like to get to the bottom of the `atexit`
behavior so that this will pass reliably. If you like, I think you'd be safe getting rid of
this part of the diff and leaving the TestFramework test as it is. I can cover the case where
we don't set the `work_dir` as part of https://issues.apache.org/jira/browse/MESOS-5850


- Greg Mann


On July 16, 2016, 2:14 a.m., Ammar Askar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50003/
> -----------------------------------------------------------
> 
> (Updated July 16, 2016, 2:14 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Vinod Kone.
> 
> 
> Bugs: MESOS-5613
>     https://issues.apache.org/jira/browse/MESOS-5613
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Propagate work_dir flag from local runs to agents/masters.
> 
> 
> Diffs
> -----
> 
>   src/local/flags.hpp f0af0d2 
>   src/local/local.cpp a543aef 
>   src/tests/test_framework_test.sh 73b4ddc 
> 
> Diff: https://reviews.apache.org/r/50003/diff/
> 
> 
> Testing
> -------
> 
> Manually tested that `mesos local` and `mesos-local` run now. Not sure if a regression
test for this would be good, please advise.
> 
> 
> Thanks,
> 
> Ammar Askar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message