mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.
Date Fri, 15 Jul 2016 02:23:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49819/#review142325
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 278)
<https://reviews.apache.org/r/49819/#comment207904>

    Update the comment with the reason why we need save the info here.



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 285)
<https://reviews.apache.org/r/49819/#comment207905>

    s/Create cgroup/Create cgroup in/



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 373 - 382)
<https://reviews.apache.org/r/49819/#comment207903>

    This method is unnecessary after we remove `cleanup`.


- haosdent huang


On July 14, 2016, 5:15 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49819/
> -----------------------------------------------------------
> 
> (Updated July 14, 2016, 5:15 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5041
>     https://issues.apache.org/jira/browse/MESOS-5041
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented `CgroupsIsolatorProcess::prepare`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp c57baec88437f68886702a40ec8a6a6458546119

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 4a9f55bf3b217405bf90943f27a976422877a99e

> 
> Diff: https://reviews.apache.org/r/49819/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message