mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Srinivas Brahmaroutu <srbra...@us.ibm.com>
Subject Re: Review Request 49688: Added cmake build for mesos tests.
Date Sun, 10 Jul 2016 01:49:03 GMT


> On July 6, 2016, 4:17 p.m., Joseph Wu wrote:
> > src/tests/CMakeLists.txt, line 17
> > <https://reviews.apache.org/r/49688/diff/1/?file=1437480#file1437480line17>
> >
> >     It does look like this MesosTestConfigure thing is unused, but I'll need to
double-check with Alex Clemmer.

We use MesosTestsConfigure to run Container tests (we can rename accordingly?) and TestsConfigure
will be used by top level tests.


> On July 6, 2016, 4:17 p.m., Joseph Wu wrote:
> > src/tests/CMakeLists.txt, line 57
> > <https://reviews.apache.org/r/49688/diff/1/?file=1437480#file1437480line57>
> >
> >     This might not work without `src/tests/main.cpp`

cmake does build a executable. It may not run at the moment until all dependent libraries
are built.


> On July 6, 2016, 4:17 p.m., Joseph Wu wrote:
> > CMakeLists.txt, lines 110-115
> > <https://reviews.apache.org/r/49688/diff/1/?file=1437479#file1437479line110>
> >
> >     It seems like this custom target will build all three tests, and then run them
sequentially afterwards.  It may be better to chain three of these custom targets together,
so that we do the same thing as autotools:
> >     1) build stout, test 
> >     2) build libprocess, test
> >     3) build mesos, test

I took out the target for mesos at the moment. I will add this once the tests are functional
in the top patch.


- Srinivas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49688/#review141011
-----------------------------------------------------------


On July 10, 2016, 1 a.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49688/
> -----------------------------------------------------------
> 
> (Updated July 10, 2016, 1 a.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
>     https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added cmake build for mesos tests.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 31601a2280fa4a07df53e4e332a7e2fb0199079c 
>   cmake/MesosConfigure.cmake b2318ed8eb4e11de43abfc15f51d12b2c0ff8fa1 
>   src/tests/CMakeLists.txt 3c530631d22aa1cfdc2c600112059601bba7d6b7 
>   src/tests/cmake/TestsConfigure.cmake PRE-CREATION 
>   src/tests/containerizer/CMakeLists.txt dab8cb07f09f5554123ede4ec8b45b60abf62eee 
> 
> Diff: https://reviews.apache.org/r/49688/diff/
> 
> 
> Testing
> -------
> 
> cmake ..
> cmake check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message