mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 43293: Ignored invalid env vars.
Date Sun, 10 Jul 2016 01:28:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43293/#review141570
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
for reopening reviews.

- Joris Van Remoortere


On March 4, 2016, 3:34 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43293/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 3:34 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4607
>     https://issues.apache.org/jira/browse/MESOS-4607
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignored invalid env vars when creating docker image.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/tests/containerizer/docker_tests.cpp 7ef52ade0d3389f9e24e3c5c7dda4f8809b9d83f 
> 
> Diff: https://reviews.apache.org/r/43293/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> $ GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="DockerImageTest.ParseInspectonImage"
--verbose
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from DockerImageTest
> [ RUN      ] DockerImageTest.ParseInspectonImage
> I0216 12:13:00.501356 1918300928 process.cpp:2489] Spawned process files@192.168.1.102:54061
> I0216 12:13:00.501369 216694784 process.cpp:2499] Resuming files@192.168.1.102:54061
at 2016-02-16 04:13:00.501399040+00:00
> I0216 12:13:00.501513 217231360 process.cpp:2499] Resuming help@192.168.1.102:54061 at
2016-02-16 04:13:00.501527040+00:00
> I0216 12:13:00.505641 1918300928 docker.cpp:398] Overriding the environment variable
'JAVA_VERSION' from '8u66' to '8u77'
> W0216 12:13:00.505677 1918300928 docker.cpp:391] Skipping invalid environment variable
'JAVA_VERSION+8u66' for 'ContainerConfig.Env'
> I0216 12:13:00.506271 214548480 process.cpp:2499] Resuming AuthenticationRouter(1)@192.168.1.102:54061
at 2016-02-16 04:13:00.506306048+00:00
> I0216 12:13:00.506393 216158208 process.cpp:2499] Resuming files@192.168.1.102:54061
at 2016-02-16 04:13:00.506411008+00:00
> I0216 12:13:00.506433 216158208 process.cpp:2604] Cleaning up files@192.168.1.102:54061
> I0216 12:13:00.506475 215621632 process.cpp:2499] Resuming help@192.168.1.102:54061 at
2016-02-16 04:13:00.506503168+00:00
> [       OK ] DockerImageTest.ParseInspectonImage (6 ms)
> [----------] 1 test from DockerImageTest (6 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (18 ms total)
> [  PASSED  ] 1 test.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message