mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.
Date Fri, 08 Jul 2016 17:16:30 GMT


> On May 3, 2016, 10:32 p.m., Michael Park wrote:
> > src/tests/persistent_volume_tests.cpp, lines 573-575
> > <https://reviews.apache.org/r/41613/diff/2/?file=1180931#file1180931line573>
> >
> >     ```cpp
> >       Resources taskResources =
> >           Resources::parse("cpus:1;mem:128;disk(" + DEFAULT_ROLE + "):32").get()
+
> >           volume;
> >     ```

Looks like the changes for multidisk support ended up shortening these lines, so this change
is no longer necessary.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41613/#review131557
-----------------------------------------------------------


On Jan. 5, 2016, 2:49 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41613/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 2:49 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `DEFAULT_ROLE` constant to persistent volume tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp 2fb57814b2805bc76981d1877603a1a033f29289 
> 
> Diff: https://reviews.apache.org/r/41613/diff/
> 
> 
> Testing
> -------
> 
> `GTEST_FILTER="PersistentVolumeTest*" bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message