mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojian...@cn.ibm.com>
Subject Re: Review Request 49780: Added a `Clock::settle()` to ensure agent has finished recovery.
Date Fri, 08 Jul 2016 05:35:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49780/#review141249
-----------------------------------------------------------


Ship it!




Ship It!

- Jay Guo


On July 8, 2016, 2:12 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49780/
> -----------------------------------------------------------
> 
> (Updated July 8, 2016, 2:12 a.m.)
> 
> 
> Review request for mesos, zhou xing, Jay Guo, haosdent huang, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We were waiting on `__recover()` to be invoked which does
> _not_ mean that the function has completed. This can lead to
> some flakiness i.e. a `503 xx` when the `post()` happens before
> the agent has finished recovery e.g., due to a context switch.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 4cb70720ec6df86ad113170fb664de1bfbd809aa 
> 
> Diff: https://reviews.apache.org/r/49780/diff/
> 
> 
> Testing
> -------
> 
> make check (gtest_repeat=1000)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message