mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 49509: Revised protobuf definition of GetState response.
Date Wed, 06 Jul 2016 00:59:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49509/#review140918
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/master/master.proto (line 272)
<https://reviews.apache.org/r/49509/#comment206286>

    Can you add a short description for this similar to what we have for other protobuf calls?
    
    Ditto for the versioned protobuf.


- Anand Mazumdar


On July 1, 2016, 11:43 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49509/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 11:43 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5489
>     https://issues.apache.org/jira/browse/MESOS-5489
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Revised protobuf definition of GetState response.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto d06258e9fd39c7eefd8ecd394e3bdfb888479b1e 
>   include/mesos/v1/master/master.proto b7cb6fdf2e4f34a11d326ac3ad3ec26525f8f343 
> 
> Diff: https://reviews.apache.org/r/49509/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message