mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ian Downes <ian.dow...@gmail.com>
Subject Re: Review Request 49273: Helper binary for executors to chroot tasks.
Date Tue, 05 Jul 2016 17:06:53 GMT


> On July 4, 2016, 10:06 a.m., Jie Yu wrote:
> > Please see the test section of https://reviews.apache.org/r/49569/
> > 
> > Let me know if that's ok or not. Thanks!

Hey, thanks for looking at this. I looked at the review for `mesos-containerizer launch` and
it just optionally creates a new mount ns. So, to actually "chroot" a task we still need something
like the functionality in this review?


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49273/#review140687
-----------------------------------------------------------


On June 27, 2016, 10:09 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49273/
> -----------------------------------------------------------
> 
> (Updated June 27, 2016, 10:09 a.m.)
> 
> 
> Review request for mesos, Joshua Cohen and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Uses the same code as the agent uses for chroot'ing on Linux, i.e., pivot_root and setting
up /dev etc. Intention is that executors (like Aurora's Thermos) can use it to chroot tasks.
> 
> Currently, the root path is specified as a flag and the remaining arguments are exec'ed.
Joshua has also requested that the root path could be specified as the first arg. @Jie, thoughts?
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 86c39fdf379ada470c9b1f86be263ef71dc47c41 
>   src/slave/containerizer/mesos-chroot.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49273/diff/
> 
> 
> Testing
> -------
> 
> Manual.
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message