mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 49610: Added test case for quota allocation with reserved resources.
Date Tue, 05 Jul 2016 08:51:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49610/
-----------------------------------------------------------

(Updated July 5, 2016, 8:51 a.m.)


Review request for mesos and Alexander Rukletsov.


Changes
-------

Move test to group together related tests, minor code cleanup.


Repository: mesos


Description
-------

This test checks that when setting aside unallocated resources to ensure
that a quota guarantee can be met, we don't use resources that have been
reserved for a different role.


Diffs (updated)
-----

  src/tests/hierarchical_allocator_tests.cpp 0498cd5e54b0e4b87a767585a77699653aa52179 

Diff: https://reviews.apache.org/r/49610/diff/


Testing (updated)
-------

`./src/mesos-tests --gtest_filter="HierarchicalAllocatorTest.QuotaSetAsideReservedResources"
--gtest_repeat=500 --gtest_break_on_failure` passes. When you apply a patch that breaks quota
allocation behavior (https://gist.github.com/neilconway/97eed34e9b0b312b8511f0f4f57fe061),
previously `make check` passes, but it fails with this new test added.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message