mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 49520: Fixed the flaky BusyMountPoint test.
Date Sun, 03 Jul 2016 17:32:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49520/#review140560
-----------------------------------------------------------




src/tests/gc_tests.cpp (line 919)
<https://reviews.apache.org/r/49520/#comment205978>

    new line above



src/tests/gc_tests.cpp (line 932)
<https://reviews.apache.org/r/49520/#comment205979>

    I prefer using `_mountPoint` than `mountPoint_`. For those guys used to google style,
a suffix `_` indicates that it's a member field.



src/tests/gc_tests.cpp (line 955)
<https://reviews.apache.org/r/49520/#comment205981>

    Ditto on using `_sandbox`



src/tests/gc_tests.cpp (line 963)
<https://reviews.apache.org/r/49520/#comment205975>

    Is it possible that mountPoint is not set but test failed? Are we leaking mounts in that
case?
    
    I would suggest that we override `CreateSlaveFlags` and save slave's work_dir in the test
fixture.
    
    During teardown, you can call fs::unmountAll(workDir) to cleanup the mounts.



src/tests/gc_tests.cpp (line 968)
<https://reviews.apache.org/r/49520/#comment205982>

    Please add `using process::Timeout` in the beginning of this file and use `Timeout` here.


- Jie Yu


On July 1, 2016, 6:22 p.m., Megha Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49520/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 6:22 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5752
>     https://issues.apache.org/jira/browse/MESOS-5752
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In ROOT_GarbageCollectorUndeletableFilesTest.BusyMountPoint there is
> a race between the task creating a file and the test looking for it
> which sometimes leads to assertion failure on the existence of the
> file.
> 
> 
> Diffs
> -----
> 
>   src/tests/gc_tests.cpp 2e23f04ea908aadcefb21e11203b95b94ec3c60b 
> 
> Diff: https://reviews.apache.org/r/49520/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message