mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 49549: Used the launch helper binary to launch user task in command executor.
Date Sat, 02 Jul 2016 05:37:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49549/#review140478
-----------------------------------------------------------



Bad patch!

Reviews applied: [49549, 49548, 49542, 49541, 49540, 49523, 49524, 49479, 49473, 49472, 49425,
49424, 49415]

Failed command: ./support/apply-review.sh -n -r 49541

Error:
2016-07-02 05:37:57 URL:https://reviews.apache.org/r/49541/diff/raw/ [1789/1789] -> "49541.patch"
[1]
error: patch failed: src/launcher/executor.cpp:676
error: src/launcher/executor.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/14076/console

- Mesos ReviewBot


On July 2, 2016, 1:02 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49549/
> -----------------------------------------------------------
> 
> (Updated July 2, 2016, 1:02 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Ian Downes, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5753
>     https://issues.apache.org/jira/browse/MESOS-5753
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently, command executor and 'mesos-containerizer launch' share a
> lot of the logic. Command executor should in fact, just use
> `mesos-containerizer launch` to launch the user task. Potentially,
> 'mesos-containerizer launch' can be also used by custom executor to
> launch user tasks.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp 63010252ffd6b1dfbe3358a1f1f4447967b824d2 
>   src/launcher/posix/executor.hpp e5f3c0a8e2d3687a5330adbf2f667db9106970c7 
>   src/launcher/posix/executor.cpp ab1dd938a7c59f52b44aafe1340c614087460f84 
>   src/slave/containerizer/mesos/launch.cpp 83f4d7f28c066a605aa84862eca9fde900ec96c6 
> 
> Diff: https://reviews.apache.org/r/49549/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message