mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 49487: Refactor master::Http::getTasks into helper function.
Date Fri, 01 Jul 2016 19:16:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49487/#review140402
-----------------------------------------------------------




src/master/http.cpp (lines 3335 - 3336)
<https://reviews.apache.org/r/49487/#comment205791>

    no need to defer, since this is a static lambda. also, just capture contentType specifically
instead of "=".
    
    ```
    return _getTasks(principal)
      .then([contentType](const mesos::master::Response::GetTasks& getTasks)
        -> Future<Response> {
      
      });
    
    ```



src/master/http.cpp (line 3345)
<https://reviews.apache.org/r/49487/#comment205792>

    extra blank line.



src/master/http.cpp (line 3397)
<https://reviews.apache.org/r/49487/#comment205793>

    new line before this.


- Vinod Kone


On July 1, 2016, 1:32 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49487/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 1:32 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5489
>     https://issues.apache.org/jira/browse/MESOS-5489
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Helper function will be also be reused for `GetState`.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 528f01f2e00ddbd15da1cc4fca27b5347c9fc798 
>   src/master/master.hpp 7388a3e7f3a0c9f0a2a286a8c8107210971b654a 
> 
> Diff: https://reviews.apache.org/r/49487/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message