mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 49420: Updated GetFrameworks v1 call in master.
Date Thu, 30 Jun 2016 23:30:30 GMT


> On June 30, 2016, 2:18 a.m., haosdent huang wrote:
> > src/master/http.cpp, line 1395
> > <https://reviews.apache.org/r/49420/diff/1/?file=1433832#file1433832line1395>
> >
> >     I saw https://github.com/apache/mesos/commit/856416754f09530582f74858566202cb5b244c70
> >     
> >     Do we need change `[=]` here as well?

not sure what was the intent behind the change. afaict, we are using "=" capture elsewhere
in this file. i will ask joerg. dropping for now.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49420/#review140097
-----------------------------------------------------------


On June 30, 2016, 2:09 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49420/
> -----------------------------------------------------------
> 
> (Updated June 30, 2016, 2:09 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Zhitao Li.
> 
> 
> Bugs: MESOS-5492
>     https://issues.apache.org/jira/browse/MESOS-5492
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change removes tasks and executors information from
> GetFrameworks call because we can get that from GetTasks
> and GetExecutors (not yet implemented) calls.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto 2e5d6eeb3a960e4f41c382d65321f18bb05ed6be 
>   include/mesos/v1/master/master.proto 93157d57dcc53b54fed2ebbc4772c689ddba2119 
>   src/master/http.cpp e5acdb8e0bbcd7a2b7e8a8bc7f4bbeaae2c4fea1 
> 
> Diff: https://reviews.apache.org/r/49420/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message