mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Haris Choudhary <haris0...@gmail.com>
Subject Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.
Date Thu, 30 Jun 2016 00:51:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49414/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Bugs: MESOS-5737
    https://issues.apache.org/jira/browse/MESOS-5737


Repository: mesos


Description
-------

Added Executor PID in /containers endpoint. Also Added Test Cases.

In order to greatly simplify the implementation for the Mesos CLI's container plugin, we need
the executor PID (Process ID) to be exposed in the /containers endpoint. [Mesos CLI Epic](https://issues.apache.org/jira/browse/MESOS-5676)
This change will introduce the pid for an executor if it was launched by the mesos containerizer
in the /containers endpoint of an agent.


Diffs
-----

  include/mesos/mesos.proto 5b15a89bbac0b33c77e305c5b188823f2704a653 
  include/mesos/v1/mesos.proto a1435278e81c8f3179d94cd9d2c3dd8c0ba82d35 
  src/slave/containerizer/mesos/containerizer.cpp a96b382f22886362a1159e1166dfe041072985ba

  src/slave/containerizer/mesos/launcher.hpp 05320f462653c31fc2f093d6c67e2182e9c794fa 
  src/slave/containerizer/mesos/launcher.cpp ff675262af8947b89f8099828665e5e5d86491d8 
  src/slave/containerizer/mesos/linux_launcher.hpp 89bb2958a41dffe4ade9c2492b9a7412f90a432d

  src/slave/containerizer/mesos/linux_launcher.cpp 5028854fa003615f158120e030866b7ec4402b66

  src/tests/containerizer/launcher.hpp c352634c4766d289706c7cc738677619d7d02ccd 
  src/tests/containerizer/mesos_containerizer_tests.cpp 6c14f6e20b4d14d5ed095670673571739101b0e4


Diff: https://reviews.apache.org/r/49414/diff/


Testing
-------

make and make check.


Thanks,

Haris Choudhary


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message