mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 49175: Added tests for libprocess linking and unlinking behavior.
Date Wed, 29 Jun 2016 23:54:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49175/
-----------------------------------------------------------

(Updated June 29, 2016, 4:54 p.m.)


Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, Artem Harutyunyan,
and Jie Yu.


Changes
-------

Depending on the system's implementation of `sh`, the `kill(...)` may only kill the shell,
without killing the underlying process.  Using `os::killtree` will do the correct thing on
all systems (i.e. tests fails on Debian and Ubuntu because of this).

Also added the appropriate cmake build changes.


Bugs: MESOS-5740
    https://issues.apache.org/jira/browse/MESOS-5740


Repository: mesos


Description
-------

Adds tests which exercise "link" semantics against remote processes.
This includes detection of `ExitedEvents` when the process exits
as well as mixing "link" semantics.

Includes a test case that emulates the failure observed in MESOS-5576.


Diffs (updated)
-----

  3rdparty/libprocess/Makefile.am 3c3249fe9799ba919ac7bd13e2ddb07a306737f0 
  3rdparty/libprocess/src/tests/CMakeLists.txt 0c659dc00fe4fde78b2b57ebcc49cb47daf162d9 
  3rdparty/libprocess/src/tests/process_tests.cpp 3fce6fc41faaa7b6e8a2a957e85de3de973a51ba

  3rdparty/libprocess/src/tests/test_linkee.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/49175/diff/


Testing (updated)
-------

See end of chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message