mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 49336: Renamed `agent_id` fields to `slave_id` for unversioned master.proto.
Date Tue, 28 Jun 2016 21:28:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49336/#review139865
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On June 28, 2016, 8:58 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49336/
> -----------------------------------------------------------
> 
> (Updated June 28, 2016, 8:58 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, Jay Guo, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change renames the `agent_id` to `slave_id` for the
> unversioned protos to keep it consistent to other unversioned
> protobuf files. Also, fixed a couple of minor issues of not
> capturing aliases by const references for consistency.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto b9936521628238fd3d215c6a05423ebbda1e94d7 
>   src/master/http.cpp e827e6948a7eec51c914975e8b77a094844cb63f 
> 
> Diff: https://reviews.apache.org/r/49336/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message