mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomasz Janiszewski <jani...@gmail.com>
Subject Re: Review Request 48910: Group frameworks by state in the webui.
Date Mon, 27 Jun 2016 10:45:26 GMT


> On June 27, 2016, 3:49 a.m., Vinod Kone wrote:
> > src/webui/master/static/frameworks.html, line 29
> > <https://reviews.apache.org/r/48910/diff/2/?file=1430180#file1430180line29>
> >
> >     should be filtered by `disconnected` boolean.
> >     
> >     a framework in master has two tags associated with it, `active` and `connected`.
so the following 4 states are theoretically possible:
> >     
> >     connected and active
> >     connected but inactive (not currently possible but maybe in the future)
> >     disconnected and active (doesn't make sense)
> >     disconnected and inactive

I'm on latest master `git_sha: "05b553ec6b0260547055fbc807ab3acce4ece234"`. There is no `disconnected`
field in frameworks returned by `/master/state`. On the other hand `/metrics/snapshot` has
fields `master/frameworks_connected` and `master/frameworks_disconnected`. Should I add this
fields to `/master/state` endpoint?


- Tomasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48910/#review139516
-----------------------------------------------------------


On June 25, 2016, 3:48 p.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48910/
> -----------------------------------------------------------
> 
> (Updated June 25, 2016, 3:48 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Deshna Jain, haosdent huang, Ross Allen, and
Vinod Kone.
> 
> 
> Bugs: MESOS-2145
>     https://issues.apache.org/jira/browse/MESOS-2145
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Create 3 groups in fameworks listing for connected,
> disconnected and completed frameworks.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/frameworks.html cfb6f4efc259419e4cb697332c8d6f2839e96970 
> 
> Diff: https://reviews.apache.org/r/48910/diff/
> 
> 
> Testing
> -------
> 
> ![screenshot](https://issues.apache.org/jira/secure/attachment/12813382/frameworks_alive.png)
> 
> Run framework (e.g. Marathon) wait until it appear on `#/frameworks`. Stop it (no graceful
shutdown with deregistration). It should be highlighted with next page update.
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message