mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 49140: Added startsWith/endsWith to support char.
Date Sun, 26 Jun 2016 08:42:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49140/#review139492
-----------------------------------------------------------




3rdparty/stout/include/stout/strings.hpp (line 376)
<https://reviews.apache.org/r/49140/#comment204744>

    Let's use `s.front()` rather than `*s.begin()`.



3rdparty/stout/include/stout/strings.hpp (line 388)
<https://reviews.apache.org/r/49140/#comment204745>

    Let's use `s.back()` rather than `*s.rbegin()`.


- Michael Park


On June 23, 2016, 2:51 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49140/
> -----------------------------------------------------------
> 
> (Updated June 23, 2016, 2:51 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-5692
>     https://issues.apache.org/jira/browse/MESOS-5692
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added startsWith/endsWith to support char.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/strings.hpp 162bdfb6c4f5a6b108761ebccd9b77e672f6dd87 
> 
> Diff: https://reviews.apache.org/r/49140/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message