mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 49088: Replaced default capture by value by explicit capture by value.
Date Sun, 26 Jun 2016 08:16:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49088/#review139489
-----------------------------------------------------------


Fix it, then Ship it!





src/master/http.cpp (lines 1922 - 1924)
<https://reviews.apache.org/r/49088/#comment204741>

    Let's maintain the formatting here.


- Michael Park


On June 25, 2016, 12:33 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49088/
> -----------------------------------------------------------
> 
> (Updated June 25, 2016, 12:33 p.m.)
> 
> 
> Review request for mesos, Jay Guo, Joris Van Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When default capture by value is used in a lambda, it's hard
> to reason within what context the lambda has to be executed
> without auditing the code.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp ad3f723ec21dd0e9f3a3f015d4de0702625cd603 
> 
> Diff: https://reviews.apache.org/r/49088/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message