mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 49062: Fixed lambda capture list for consistency.
Date Sun, 26 Jun 2016 08:09:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49062/#review139488
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On June 25, 2016, 12:32 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49062/
> -----------------------------------------------------------
> 
> (Updated June 25, 2016, 12:32 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Our jsonify library consumes the lambdas immediately, without saving
> them internally or running asynchronously. Hence it is OK to capture
> by reference in this case.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp ad3f723ec21dd0e9f3a3f015d4de0702625cd603 
>   src/slave/http.cpp c038bf0c9680ec86f77f1a27efeb7354a9e67627 
> 
> Diff: https://reviews.apache.org/r/49062/diff/
> 
> 
> Testing
> -------
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message