mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 49157: Added missing comments for operator API protos.
Date Fri, 24 Jun 2016 01:58:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49157/
-----------------------------------------------------------

(Updated June 24, 2016, 1:58 a.m.)


Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay Guo, Shuai Lin,
and Vinod Kone.


Changes
-------

Address @vinodkone's comments.


Bugs: MESOS-5695
    https://issues.apache.org/jira/browse/MESOS-5695


Repository: mesos


Description
-------

Add missing comments for `GET_ROLES`, `GET_WEIGHTS`, `SUBSCRIBE`,
`CREATE_VOLUMES`, `DESTROY_VOLUMES`, `SET_QUOTA` in operator API
protos.


Diffs (updated)
-----

  include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 
  include/mesos/v1/master/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 
  src/master/master.cpp d89c049326358bad509bb1455c81eb11610eeeb8 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 92b33111799cb4e1c8bc2051381e1254d701d95c

  src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 7678a7c81c3cdb27410c1f066021eb34bd02a83f

  src/slave/containerizer/mesos/isolators/network/cni/paths.cpp f9056c90f1075cb19c4f554e7d5b629561d06035

  src/tests/containerizer/cni_isolator_tests.cpp 991823b96f8eac7539625ef0f1e045e6a10464ac


Diff: https://reviews.apache.org/r/49157/diff/


Testing
-------


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message