mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 49069: Checkpointed CNI network config for container in the container dir.
Date Wed, 22 Jun 2016 21:58:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49069/#review139152
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 973)
<https://reviews.apache.org/r/49069/#comment204300>

    s/Conf/Config/



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 981)
<https://reviews.apache.org/r/49069/#comment204301>

    space before `'`



src/slave/containerizer/mesos/isolators/network/cni/paths.hpp (line 64)
<https://reviews.apache.org/r/49069/#comment204298>

    s/Conf/Config/


- Jie Yu


On June 22, 2016, 8:13 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49069/
> -----------------------------------------------------------
> 
> (Updated June 22, 2016, 8:13 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5310
>     https://issues.apache.org/jira/browse/MESOS-5310
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Checkpointed CNI network config for container in the container dir.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 8cf5fcb1e63873b2a3eca843130a361f25a6e825

>   src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 8af50c11b00240ac1d24605b119acbd96aaa50be

>   src/slave/containerizer/mesos/isolators/network/cni/paths.cpp b3fb0a32e3e74ca859ca58085efed5a87e4e626b

> 
> Diff: https://reviews.apache.org/r/49069/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message