mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 49054: Fix ContainerizerTest.ROOT_CGROUPS_BalloonFramework.
Date Wed, 22 Jun 2016 04:56:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49054/#review139015
-----------------------------------------------------------



Patch looks great!

Reviews applied: [49054]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On June 22, 2016, midnight, Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49054/
> -----------------------------------------------------------
> 
> (Updated June 22, 2016, midnight)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-5660
>     https://issues.apache.org/jira/browse/MESOS-5660
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> https://reviews.apache.org/r/48954/ did not set the 
> `--executor_environment_variables` agent flag in the correct place.
> This caused the balloon framework to fail with flag validation errors.
> Since this test expects a failure, the test would always succeed
> for the wrong reason.
> 
> 
> Diffs
> -----
> 
>   src/tests/balloon_framework_test.sh 54129fb11004c86026086f410198afee002ac088 
> 
> Diff: https://reviews.apache.org/r/49054/diff/
> 
> 
> Testing
> -------
> 
> sudo ./bin/mesos-tests.sh
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message