mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 45086: Enable cgroups unified isolator in isolation.
Date Tue, 21 Jun 2016 06:27:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45086/#review138784
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.cpp (line 167)
<https://reviews.apache.org/r/45086/#comment203976>

    To keep the backward compatibility, I think maybe we should not expose `cgroups/cpuacct`
to end user in the `--isolation` flag. In the current Mesos agent implmentation, if user specifies
`--isolation=cgroups/cpu`, that implies both `cpu` and `cpuacct` subsystems will be enabled
which are internally handled in `CgroupsCpushareIsolatorProcess`.
    
    In the unified cgroup isolator, I think we should do the same: if user specifies `cgroups/cpu`
in `--isolation` flag, we should let `CpuSubsystem` to handle both `cpu` and `cpuacct` subsystem.
In this way, I believe the existing user experience will not be changed at all.


- Qian Zhang


On June 20, 2016, 12:50 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45086/
> -----------------------------------------------------------
> 
> (Updated June 20, 2016, 12:50 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, Kevin Klues,
and Qian Zhang.
> 
> 
> Bugs: MESOS-5041
>     https://issues.apache.org/jira/browse/MESOS-5041
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable cgroups unified isolator in isolation.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp d6a91113da322dc58e1d3dd3e03353631b6dafee

> 
> Diff: https://reviews.apache.org/r/45086/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message