mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Review Request 49000: Reordered function definitions in master actor HTTP handlers.
Date Tue, 21 Jun 2016 05:05:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49000/
-----------------------------------------------------------

Review request for mesos, Abhishek Dasgupta, zhou xing, Jay Guo, haosdent huang, and Vinod
Kone.


Repository: mesos


Description
-------

This change performs the following function definition reordering:

- It groups pre v1 API/v1 Master API handlers nearby for better
readability. There were already some functions already doing this.
- For some handlers that use a helper function, it defines them
_before_ the HELP string variable. This means that now the
HELP strings immediatly precede the handler implementation
which is more intuitive to the reader.


Diffs
-----

  src/master/http.cpp 3a53ef74f3e80e832804a21cebe0fc9e405420cb 

Diff: https://reviews.apache.org/r/49000/diff/


Testing
-------

make check (would be doing a similar change for the agent)


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message