mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhishek Dasgupta <a10gu...@linux.vnet.ibm.com>
Subject Re: Review Request 48976: Remove default values for the `Roles` protobuf.
Date Tue, 21 Jun 2016 03:42:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48976/#review138759
-----------------------------------------------------------


Ship it!




Ship It!

- Abhishek Dasgupta


On June 20, 2016, 11:34 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48976/
> -----------------------------------------------------------
> 
> (Updated June 20, 2016, 11:34 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta and Vinod Kone.
> 
> 
> Bugs: MESOS-5494
>     https://issues.apache.org/jira/browse/MESOS-5494
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change removes the default values from the `Roles`
> protobuf as it's _strictly_ a response type sent by the master
> and it already has those values. Also, modified `weights`
> to be a required field.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 54e3d1e278e745c09929c015410440eae4d47446 
>   include/mesos/v1/mesos.proto e644ce2c16e5677695df513c716c65d180e8e79d 
>   src/master/http.cpp ccf0a4e1e6c6f004c7890cc142206f09e76a76c3 
> 
> Diff: https://reviews.apache.org/r/48976/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message