mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.
Date Mon, 20 Jun 2016 00:34:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48928/#review138506
-----------------------------------------------------------




docs/upgrades.md (line 255)
<https://reviews.apache.org/r/48928/#comment203695>

    s/dependence/dependency/ ?
    
    esp the last occurence in this para.



docs/upgrades.md (line 262)
<https://reviews.apache.org/r/48928/#comment203696>

    Is libelf a run-time dep as well? I thought it was a build-time dep only? I'm thinking
more and more that we should guard this dep on a config or run time flag. cc @bmahler.


- Vinod Kone


On June 19, 2016, 7:30 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48928/
> -----------------------------------------------------------
> 
> (Updated June 19, 2016, 7:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, haosdent huang, Vinod Kone, and Zhitao Li.
> 
> 
> Bugs: MESOS-5630
>     https://issues.apache.org/jira/browse/MESOS-5630
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added info about external `libelf` dependence to `upgrades.md`.
> 
> 
> Diffs
> -----
> 
>   docs/upgrades.md 61b7cd3ab45d09f3e4785e00bb8622421952d253 
> 
> Diff: https://reviews.apache.org/r/48928/diff/
> 
> 
> Testing
> -------
> 
> Ran the site docker to verify everything looked OK.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message