mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48935: Fixed flakiness in some of the tests using scheduler library.
Date Mon, 20 Jun 2016 00:06:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48935/#review138501
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On June 19, 2016, 10:47 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48935/
> -----------------------------------------------------------
> 
> (Updated June 19, 2016, 10:47 p.m.)
> 
> 
> Review request for mesos, Jose Guilherme Vanz and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These tests piggyback on the old `connected` future. If the new
> connection to the master takes some time to setup, we might end
> up sending a call to the master before the connection is set up
> since the `connected` future is already set from the last
> invocation. While this succeeds now, but this might show more
> flakiness once MESOS-5359 is committed.
> 
> 
> Diffs
> -----
> 
>   src/tests/http_fault_tolerance_tests.cpp baa07395b9bd588daa5438369954584787d7952a 
>   src/tests/scheduler_tests.cpp b1831052ef2ef4bc4f8f6ecabbb95f309378fa25 
> 
> Diff: https://reviews.apache.org/r/48935/diff/
> 
> 
> Testing
> -------
> 
> make check (gtest_repeat=1000)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message