mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 48918: Removed explicit authorization results in Mesos.
Date Sun, 19 Jun 2016 22:40:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48918/#review138488
-----------------------------------------------------------




src/slave/http.cpp 
<https://reviews.apache.org/r/48918/#comment203675>

    Technically, this relates not only to authz failures, but to every future that may fail
on the way.
    
    I think it is fine to remove it here for now, because the log message does not really
bring any value (assuming failure is logged by libprocess). However, we should come up with
a "template" for HTTP request handlers, so that error handling is not chosen arbitrary. It
would be great to have several stages (e.g., authn, authz, parsing, validation) and standardize
on error codes returning in case of failures in each case. Could you please create a ticket
for this?



src/slave/http.cpp (lines 1084 - 1088)
<https://reviews.apache.org/r/48918/#comment203679>

    How about this one?


- Alexander Rukletsov


On June 19, 2016, 3:02 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48918/
> -----------------------------------------------------------
> 
> (Updated June 19, 2016, 3:02 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, Benjamin Mahler,
Greg Mann, and Kapil Arya.
> 
> 
> Bugs: MESOS-5637
>     https://issues.apache.org/jira/browse/MESOS-5637
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removing the explicit authorization results as formerly returned by
> some authorizer invocations in Mesos, the returned future falls
> through/back to the HTTP proxy handler of libprocess. This change
> allows us to reduce the amount of failure result handlers.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp a6beb1721958a77886f0aa535346e2ff33bd5d04 
>   src/slave/http.cpp 77834111bf51b58ba5e12f262b725202f7d3a7bf 
> 
> Diff: https://reviews.apache.org/r/48918/diff/
> 
> 
> Testing
> -------
> 
> make check & functional testing.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message