mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.
Date Sat, 18 Jun 2016 17:00:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48094/#review138412
-----------------------------------------------------------




src/master/http.cpp (lines 1456 - 1460)
<https://reviews.apache.org/r/48094/#comment203577>

    Because you have already call `contains` above, I think here could
    ```
    getRole.set_weight(master->weights[name])
    ```
    because the type of `master->weights` is `hashmap<std::string, double> weights;`.



src/master/http.cpp (lines 1465 - 1473)
<https://reviews.apache.org/r/48094/#comment203578>

    Same here, I think could
    ```
          Role* role = master->activeRoles[name];
    
          getRole.mutable_resources()->CopyFrom(role.get()->resources());
    
          foreachkey (const FrameworkID& frameworkId, role.get()->frameworks) {
            getRole.add_frameworks()->CopyFrom(frameworkId);
          }
    ```



src/tests/api_tests.cpp (lines 459 - 475)
<https://reviews.apache.org/r/48094/#comment203579>

    I suggest change this to
    ```
      v1::Resources expectedResources =
        v1::Resources::parse(slaveFlags.resources).get();
    
      bool matched = false;
      foreach (const xxx& role, v1Response->get_roles().roles()) {
        if (role.name() == "role2") {
          ASSERT_EQ(2.5, role.weight());
          ASSERT_EQ(expectedResources, roles.resources());
          matched = true;
        }
      }
      ASSERT_TRUE(matched);
    ```


- haosdent huang


On June 18, 2016, 4:21 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48094/
> -----------------------------------------------------------
> 
> (Updated June 18, 2016, 4:21 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5494
>     https://issues.apache.org/jira/browse/MESOS-5494
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented GET_ROLES Call in v1 master API.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto fa92240 
>   include/mesos/mesos.proto e4c5bd3 
>   include/mesos/v1/master/master.proto 59e978f 
>   include/mesos/v1/mesos.proto 9be22f0 
>   src/master/http.cpp a6beb17 
>   src/master/master.hpp 618d928 
>   src/tests/api_tests.cpp afa5ffa 
> 
> Diff: https://reviews.apache.org/r/48094/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04:
> 
> sudo GTEST_FILTER="*MasterAPITest.*" make -j2 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message