mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 46026: Documented `Socket::shutdown()` member function in libprocess.
Date Fri, 17 Jun 2016 22:07:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46026/#review138325
-----------------------------------------------------------



While it's nice to document that this is internally only doing a receive-side shutdown, I'm
left wondering why. And now that it's documented, the restriction looks intentional but the
intention is absent. It would be of great help to the reader of this code to include it!

If we're hesistant to change it to `shutdown(int how)` to match the POSIX API and avoid confusion,
it seems to be only because there is a potential reason for only allowing `SHUT_RD`. Let's
get context from benh and joris to figure that out. If it was intentional, let's include the
reason in your comment, otherwise let's allow the caller to specify `how`.

- Benjamin Mahler


On April 11, 2016, 11:53 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46026/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 11:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is slightly confusing, because it doesn't match the
> semantics of the shutdown(2) POSIX function.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/socket.hpp 4cb49680d1304899a4ee675ac07379e51d9c55b1

> 
> Diff: https://reviews.apache.org/r/46026/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message