mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 48877: Added evolve logic for `master::Event` -> `v1::master::Event`.
Date Fri, 17 Jun 2016 21:02:53 GMT


> On June 17, 2016, 8:30 p.m., Zhitao Li wrote:
> > src/internal/evolve.hpp, lines 121-123
> > <https://reviews.apache.org/r/48877/diff/1/?file=1422648#file1422648line121>
> >
> >     Move this line next to `v1::master::Response` so it's easy to find?

hmm, I had grouped all the overloads that return `Event` together i.e. scheduler/event/master
for consistency.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48877/#review138303
-----------------------------------------------------------


On June 17, 2016, 8:17 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48877/
> -----------------------------------------------------------
> 
> (Updated June 17, 2016, 8:17 p.m.)
> 
> 
> Review request for mesos, Vinod Kone and Zhitao Li.
> 
> 
> Bugs: MESOS-5609
>     https://issues.apache.org/jira/browse/MESOS-5609
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added evolve logic for `master::Event` -> `v1::master::Event`.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.hpp 5f3e267fa3a0420fcbed7be6f13ee76bf85cb182 
>   src/internal/evolve.cpp 93719127e75b4ba299f8d0a7fdeb4681818d30db 
> 
> Diff: https://reviews.apache.org/r/48877/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message