mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 46875: Some cleanup in weights_handler.cpp.
Date Fri, 17 Jun 2016 20:36:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46875/#review138309
-----------------------------------------------------------


Ship it!




Ship It!

- Adam B


On April 30, 2016, 11:52 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46875/
> -----------------------------------------------------------
> 
> (Updated April 30, 2016, 11:52 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> There is no need to add () for request body as there is already
> '' for the message.
> 
> 
> Diffs
> -----
> 
>   src/master/weights_handler.cpp 07cc9920ca61f3e6e9e5b8be37884ed6f0d4f975 
> 
> Diff: https://reviews.apache.org/r/46875/diff/
> 
> 
> Testing
> -------
> 
> Before fix:
> root@mesos002:~/test# curl -d weight.json -X PUT http://192.168.56.12:5050/weights
> Failed to parse update weights request JSON ('weight.json'): syntax error at line 1 near:
weight.js
> 
> After fix:
> root@mesos002:~/test# curl -d weight.json -X PUT http://192.168.56.12:5050/weights
> Failed to parse update weights request JSON 'weight.json': syntax error at line 1 near:
weight.json
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message