mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.
Date Wed, 15 Jun 2016 23:01:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48315/
-----------------------------------------------------------

(Updated June 15, 2016, 11:01 p.m.)


Review request for mesos, Neil Conway and Jiang Yan Xu.


Bugs: MESOS-5448
    https://issues.apache.org/jira/browse/MESOS-5448


Repository: mesos


Description
-------

Root of a MOUNT disk is not deleted on volume DELETE. When we do a
CREATE on a persistent volume and the root directory exists (which
can happen for MOUNT disks), we allow the operation only if the
contents within the root directory is empty. If not, we do not update
the checkpoint with this volume and exit, so as to cleanup when the
slave restarts and handles the CheckpointResourcesMessage.


Diffs (updated)
-----

  docs/multiple-disk.md 20b99e0e57360ad43804201b27e593d7ed48ce2c 
  src/slave/slave.cpp 0af04d6fe53f92e03905fb7b3bec72b09d5e8e57 
  src/tests/persistent_volume_tests.cpp 5125a8da44759d1235fddac26e9eb5436c3d037b 

Diff: https://reviews.apache.org/r/48315/diff/


Testing
-------

All tests passed.


Thanks,

Anindya Sinha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message