mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomasz Janiszewski <jani...@gmail.com>
Subject Re: Review Request 48320: Update C++ style checker to prevent NULL usage.
Date Wed, 15 Jun 2016 12:47:49 GMT


> On June 14, 2016, 2:36 p.m., Benjamin Bannier wrote:
> > support/cpplint.py, line 1
> > <https://reviews.apache.org/r/48320/diff/1/?file=1408633#file1408633line1>
> >
> >     Not in this file, but do we need to update `cpplint.patch` as well? We seem
to have stopped doing that at some point.
> 
> Tomasz Janiszewski wrote:
>     Good question. I didn't do that becouse I saw it's out of sync. Maybe it could be
deleted but present a  way of generating it with` git diff`?
> 
> Tomasz Janiszewski wrote:
>     @AdamB @bbanier How diff was generated before? I tried `git diff 38e92332f9b7529f946ecd4fba0df1cd7d493937..master
 support/cpplint.py` but it generates bigger diff then I expected.
> 
> Benjamin Bannier wrote:
>     I cannot comment on the historic context, but I checked out upstream cpplint from
https://github.com/google/styleguide and compared against our initial checking of `cpplint.py`
in `38e9233` (it doesn't appear that we ever pulled in upstream changes). Our version appears
to be based on upstream's `5d00c5679eb9a70eb234bc1c91aeb17ec27eb875`.
>     
>     Since the patch file got out of sync you'll see a diff containing more than just
your changes. It would be great if you could prefix this RR with the changes that lapsed.

I created patch updating this patch https://reviews.apache.org/r/48728/


- Tomasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48320/#review137508
-----------------------------------------------------------


On June 15, 2016, 11:45 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48320/
> -----------------------------------------------------------
> 
> (Updated June 15, 2016, 11:45 a.m.)
> 
> 
> Review request for mesos, Adam Berry, Benjamin Mahler, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-3243
>     https://issues.apache.org/jira/browse/MESOS-3243
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update C++ style checker to prevent NULL usage.
> 
> 
> Diffs
> -----
> 
>   support/cpplint.py 96e7fbcfe84067becbac89de909a2c6bdf99a60b 
>   support/mesos-style.py 35ef7867c45afa02f0c74b86149f2e0489fe2d15 
> 
> Diff: https://reviews.apache.org/r/48320/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message