mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 47663: Added image user to 'ContainerLaunchInfo'.
Date Tue, 14 Jun 2016 23:16:55 GMT


> On June 14, 2016, 8:47 a.m., Guangya Liu wrote:
> > include/mesos/slave/isolator.proto, lines 131-139
> > <https://reviews.apache.org/r/47663/diff/3/?file=1417333#file1417333line131>
> >
> >     I saw that from https://github.com/docker/docker/blob/master/image/spec/v1.md#container-runconfig-field-descriptions,
all of those info belong to `user`.
> >     
> >     Does it make sense to put `user` to a message proto?
> >     
> >     message UserInfo {
> >       // The user name or UID in the container. If 'user' is numerical,
> >       // it is an UID. Otherwise, it is an username.
> >       optional string user = 7;
> >     
> >       // The group name or GID in the container. If 'group' is numerical,
> >       // it is a GID. Otherwise, it is a groupname.
> >       optional string group = 8;
> >     
> >       // TODO: Add repeated supplementary groups.
> >     }
> >     
> >     message ContainerLaunchInfo {
> >       ...
> >       optional UserInfo user = 7;
> >     }

This is not only for docker, but also for appc etc. Need to decide after user ns staff. Let's
leave a TODO and not create that for now. Thanks:)


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47663/#review137523
-----------------------------------------------------------


On June 13, 2016, 4:47 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47663/
> -----------------------------------------------------------
> 
> (Updated June 13, 2016, 4:47 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin Klues, and Timothy
Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added image user to 'ContainerLaunchInfo'.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 
> 
> Diff: https://reviews.apache.org/r/47663/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message