mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 47660: Fixed agent switch user redundant logic in 'getExecutorInfo'.
Date Mon, 13 Jun 2016 23:45:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47660/
-----------------------------------------------------------

(Updated June 13, 2016, 4:45 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin Klues, and Timothy
Chen.


Summary (updated)
-----------------

Fixed agent switch user redundant logic in 'getExecutorInfo'.


Repository: mesos


Description (updated)
-------

Since the 'user' in 'FrameworkInfo' is a required field,
so 'fromeworkInfo.has_user()' is always true. Currently
in our semantics, if the operator specifies the framework
user as an empty string, mesos will automagically set it
as the current host user. So the slave will always obtain
the user from 'FrameworkInfo', and 'switch_user' defaults
to be true from agent flag. We would prefer not to change
this semantics because a long deprecation cycle is needed.
So in this patch, we just fix the redundant check in slave
'getExecutorInfo' logic.


Diffs (updated)
-----

  src/slave/slave.cpp d635dd2c6f6fce5a9eeefc5dcdf84e00cdc833b6 

Diff: https://reviews.apache.org/r/47660/diff/


Testing
-------

make check


Thanks,

Gilbert Song


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message