mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48613: Added validation logic for UUID's.
Date Mon, 13 Jun 2016 22:17:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48613/#review137406
-----------------------------------------------------------




3rdparty/stout/include/stout/uuid.hpp (lines 54 - 78)
<https://reviews.apache.org/r/48613/#comment202536>

    As suggested by Neil in the subsequent review, lets have `fromBytes()` return a Try<UUID>
instead and do the validation there.
    
    Should we also protect `fromString()` from invalid UUID strings? If yes, lets change that
to return Try<UUID> as well.


- Vinod Kone


On June 13, 2016, 6:51 a.m., Deshna Jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48613/
> -----------------------------------------------------------
> 
> (Updated June 13, 2016, 6:51 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5224
>     https://issues.apache.org/jira/browse/MESOS-5224
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds a `validateFromBytes` function for validating
> UUID's by checking if they are one of the supported UUID
> versions.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/uuid.hpp e3cf21ff986112694a417981c22009323cb23987 
>   3rdparty/stout/tests/uuid_tests.cpp 50295ad25843a3938a5a58f5ba7f082f8ffeba45 
> 
> Diff: https://reviews.apache.org/r/48613/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Deshna Jain
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message