mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yanyan Hu <yanya...@cn.ibm.com>
Subject Re: Review Request 48593: Refactor Ranges Subtraction.
Date Mon, 13 Jun 2016 08:24:28 GMT


> On June 13, 2016, 3:40 a.m., Klaus Ma wrote:
> > src/common/values.cpp, lines 411-419
> > <https://reviews.apache.org/r/48593/diff/2/?file=1415977#file1415977line411>
> >
> >     Any data on performance improvement?
> 
> Yanyan Hu wrote:
>     Hi, Klaus, performance data is listed here: https://issues.apache.org/jira/browse/MESOS-5425#
thanks.
> 
> Klaus Ma wrote:
>     Thanks; according to the data. It seems worse performance when # < 200, but better
performance when # > 200. I'm not sure which is general case in production :).
> 
> Yanyan Hu wrote:
>     Hi, if you refer to the latest result, the performance is always better than current
implemenation :)
>     https://issues.apache.org/jira/browse/MESOS-5425?focusedCommentId=15303641&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15303641
> 
> Klaus Ma wrote:
>     Great! would you add some benchmark test for this patch? I think current test cases
has covered the general feature, but not benchmark for it :).

Yes, I'm working on it. Will post it later :)


- Yanyan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48593/#review137223
-----------------------------------------------------------


On June 12, 2016, 8:03 a.m., Yanyan Hu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48593/
> -----------------------------------------------------------
> 
> (Updated June 12, 2016, 8:03 a.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-5425
>     https://issues.apache.org/jira/browse/MESOS-5425
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch reimplement Ranges subtraction using
> IntervalSet data type: Ranges values will be
> converted to IntervalSet values for subtraction
> and the result will be converted back to Ranges
> after subtraction is done. This change is for
> fixing jira MESOS-5425.
> 
> 
> Diffs
> -----
> 
>   src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b 
> 
> Diff: https://reviews.apache.org/r/48593/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yanyan Hu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message