mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 48458: Corrected comment for QuotaProvidesGuarantee.
Date Thu, 09 Jun 2016 23:57:16 GMT


> On 六月 9, 2016, 11:52 p.m., Benjamin Mahler wrote:
> > Ship It!
> 
> Benjamin Mahler wrote:
>     We should clarify that QuotaProvidesGuarantee is a test in the summary of this review
because it will become the commit message.

Thanks Ben, got it.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48458/#review136934
-----------------------------------------------------------


On 六月 9, 2016, 2:38 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48458/
> -----------------------------------------------------------
> 
> (Updated 六月 9, 2016, 2:38 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Corrected comment for QuotaProvidesGuarantee.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp e4579cb7978c966f639c0d2c196884e522b372c2

> 
> Diff: https://reviews.apache.org/r/48458/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message