mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.
Date Thu, 09 Jun 2016 22:05:46 GMT


> On June 9, 2016, 10 p.m., Vinod Kone wrote:
> > src/master/http.cpp, line 2874
> > <https://reviews.apache.org/r/48257/diff/2/?file=1412869#file1412869line2874>
> >
> >     to be consistent with how we did others, lets have this function return JSON::Object,
i.e., JSON::Protobuf(schedule)
> >     
> >     that way the evolve overload can still take JSON::Object.

looks like you are doing the same thing in the next review as well. i guess that's a pattern
we could use as well. dropping this.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48257/#review136907
-----------------------------------------------------------


On June 9, 2016, 5:49 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48257/
> -----------------------------------------------------------
> 
> (Updated June 9, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-5504
>     https://issues.apache.org/jira/browse/MESOS-5504
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 
>   src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b 
>   src/master/http.cpp 6e1bf9557a854a89fa9173223295816a9e114e7c 
>   src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb 
> 
> Diff: https://reviews.apache.org/r/48257/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message