mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 48423: Simplified the test for Docker::version.
Date Wed, 08 Jun 2016 22:17:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48423/#review136714
-----------------------------------------------------------


Ship it!




FYI, your description is currently above the 72 character line limit :)


src/tests/containerizer/docker_tests.cpp (line 248)
<https://reviews.apache.org/r/48423/#comment201825>

    Might help to point out the subtle difference (s/.fc22/-fc22/) this `docker` has.


- Joseph Wu


On June 8, 2016, 12:18 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48423/
> -----------------------------------------------------------
> 
> (Updated June 8, 2016, 12:18 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test assumes that a Try is Some, and the test can be written more succinctly.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_tests.cpp 7ef52ade0d3389f9e24e3c5c7dda4f8809b9d83f 
> 
> Diff: https://reviews.apache.org/r/48423/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message