mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 45952: Implemented support for passing agent default docker config.
Date Tue, 07 Jun 2016 01:02:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45952/#review136387
-----------------------------------------------------------




src/uri/fetchers/docker.cpp (line 281)
<https://reviews.apache.org/r/45952/#comment201409>

    We typically use leading underscore for function parameters and the non leading underscore
version for the field members.



src/uri/fetchers/docker.cpp (line 319)
<https://reviews.apache.org/r/45952/#comment201408>

    `s/_cachedAuths/auths/`
    
    Also, why optional? what's the difference between None() and an empty hashmap? I would
suggest that we use hashmap here (without optional).



src/uri/fetchers/docker.cpp (line 576)
<https://reviews.apache.org/r/45952/#comment201427>

    I would rename this to uri, and rename the existing uri to authServerUri.
    
    ALso, please add a comment about why you need to pass in the uri here.



src/uri/fetchers/docker.cpp (line 635)
<https://reviews.apache.org/r/45952/#comment201404>

    Ideally, we should do that after getting the 401 response. Can you add a TODO here?
    
    Also, i think from docker 1.11, it support OAuth2, so you probably should add another
TODO here.
    
    I think we should think about how are we going to support both. You should mention that
in the TODO.



src/uri/fetchers/docker.cpp (lines 644 - 647)
<https://reviews.apache.org/r/45952/#comment201429>

    Can you figure out how exactly docker does that? It's better to understand their logic,
rather than treat it as a black box?


- Jie Yu


On May 25, 2016, 1:33 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45952/
> -----------------------------------------------------------
> 
> (Updated May 25, 2016, 1:33 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4938
>     https://issues.apache.org/jira/browse/MESOS-4938
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented support for passing agent default docker config.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp eeec94326a4fd67675df10e0b6a32267e555fa96

>   src/uri/fetchers/docker.hpp c855a2b55a07bb398f7547b44a85b8ba2d2b2ec3 
>   src/uri/fetchers/docker.cpp ab8f5e05758b7de2573605c81ac80e656bb1db24 
> 
> Diff: https://reviews.apache.org/r/45952/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Tested with mesos-execute, using a private repo from docker hub. Both cases are tested:
> 1. --docker_registry=private_registry
> 2. private_registry/repo
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message