mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 48255: Replaced `NULL` with `nullptr` in libprocess.
Date Sun, 05 Jun 2016 20:40:06 GMT


> On June 5, 2016, 5:49 a.m., Tomasz Janiszewski wrote:
> > 3rdparty/libprocess/include/process/windows/subprocess.hpp, line 66
> > <https://reviews.apache.org/r/48255/diff/1/?file=1406619#file1406619line66>
> >
> >     This could be left as is.
> 
> Tomasz Janiszewski wrote:
>     On the other hand `git grep -w NULL` will show this file, so code won't be NULL free

I changed this becase "NULL-terminated" is actually incorrect anyway.
That is, the "null" in "null-terminated string" refers to the null character `'\0'` (a.k.a
`NUL`), not `NULL`.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48255/#review136203
-----------------------------------------------------------


On June 5, 2016, 1:01 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48255/
> -----------------------------------------------------------
> 
> (Updated June 5, 2016, 1:01 a.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski and Neil Conway.
> 
> 
> Bugs: MESOS-3243
>     https://issues.apache.org/jira/browse/MESOS-3243
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/async.hpp 84fd21123b0cb10dc7de7fe7f758d87a8b036376

>   3rdparty/libprocess/include/process/defer.hpp 8fb4f3fec9b19a6c2f707cb4bf7a67447281f21c

>   3rdparty/libprocess/include/process/dispatch.hpp a4c35b2a5668df79415dc5156358df3cd0621d11

>   3rdparty/libprocess/include/process/event.hpp c44dc259f240b040aa52234c7d50b1b8cc2566d9

>   3rdparty/libprocess/include/process/executor.hpp fbf9251e7a69398609f7a8df7729788c988f3d3b

>   3rdparty/libprocess/include/process/gc.hpp 799468ebe49f2a49d325f40ffd8acea727abf74c

>   3rdparty/libprocess/include/process/gmock.hpp 8b98249678cef303c1f44ab26672f4566382270e

>   3rdparty/libprocess/include/process/mutex.hpp 9b0470c3e4b708dff0aa315e234c2d0cf1dc7436

>   3rdparty/libprocess/include/process/owned.hpp c1a04cc86c224340f388efd59a84073b71716629

>   3rdparty/libprocess/include/process/pid.hpp 0791dc182ccc18552834fbc5a2e4c7a9b7a3f0dc

>   3rdparty/libprocess/include/process/posix/subprocess.hpp 36bbe284e823656c6cf37cab8a8eea8894cef8eb

>   3rdparty/libprocess/include/process/process.hpp 3a0d244de7e70508760477d6907939c63ed3d11a

>   3rdparty/libprocess/include/process/protobuf.hpp bbb9e6fd0e6ef9edda21b6792bfca1dc34ef675e

>   3rdparty/libprocess/include/process/queue.hpp 6b4dd77ffbfeec87ba530d3833ce8aa13401ffd0

>   3rdparty/libprocess/include/process/shared.hpp 833c237a7f79c79f5168dfd09a6044deb58d7deb

>   3rdparty/libprocess/include/process/windows/subprocess.hpp 8a817978a7fd0f47269e8e97ac33bc804e8fd0db

>   3rdparty/libprocess/src/clock.cpp c402ed6de53818831eeb5bb15c20880c99d30e8e 
>   3rdparty/libprocess/src/decoder.hpp 2c41ce9f00c857aa320b1d2cfa3b1048c316976a 
>   3rdparty/libprocess/src/encoder.hpp 69163830eaa9f77132a16fc14351b309144827bf 
>   3rdparty/libprocess/src/http.cpp 8b5c0f4864b779a4388891ad44562ab81bb2f062 
>   3rdparty/libprocess/src/libev.hpp 3995a2e891daee99200757fd5c3ad646051342c0 
>   3rdparty/libprocess/src/libev.cpp 1269bf8eb30cc3d51734cc0173b5296730734ac2 
>   3rdparty/libprocess/src/libevent.hpp 4d0647ee9784674dab46f313b7fd03c70227ad02 
>   3rdparty/libprocess/src/libevent.cpp f5b867507b0f8c6424f184d364ff3c0b9e360581 
>   3rdparty/libprocess/src/libevent_poll.cpp 43a1abb77ce40f53fb33cc30556279ab8b901dc2

>   3rdparty/libprocess/src/libevent_ssl_socket.hpp 9b6ba6429d061e5dbe0dd82224760189a8b10b48

>   3rdparty/libprocess/src/libevent_ssl_socket.cpp 2f844c2844e317f3523f2981cc209fe08a9717ef

>   3rdparty/libprocess/src/metrics/metrics.cpp 184b1d07f6aaf331ce451eb119ca151a33a2895d

>   3rdparty/libprocess/src/openssl.cpp 81e42221773159ab5c3f5bdbc9a4e54a6d256d48 
>   3rdparty/libprocess/src/process.cpp be120fb85583d438401c24a57dac803be3b5e5d2 
>   3rdparty/libprocess/src/process_reference.hpp 927255d463c44e2230241d649672e075cefcf016

>   3rdparty/libprocess/src/reap.cpp 69b33ebf3a2e2df167ddcde9a00910316b7da91e 
>   3rdparty/libprocess/src/ssl/utilities.cpp db8ad06874550ad8f16019f714589b2adf948d90

>   3rdparty/libprocess/src/subprocess_windows.cpp cba49902953db77c9b173dd3bdec502265a666a4

>   3rdparty/libprocess/src/tests/benchmarks.cpp e8bbc55f0f9aeabe7612a2ced5299cc01202b1f6

>   3rdparty/libprocess/src/tests/owned_tests.cpp fb00ff4c172297fd38ed4f8a5ab4dd77735a84c3

>   3rdparty/libprocess/src/tests/shared_tests.cpp 8997c38883ab8941ea687dedb69c7019da295b0d

>   3rdparty/libprocess/src/time.cpp a6c3f3de69e056544406f4416c2d0aea06adc34d 
> 
> Diff: https://reviews.apache.org/r/48255/diff/
> 
> 
> Testing
> -------
> 
> Manual eye test + `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message