mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 46158: Completed implementation of the cgroups unified isolator.
Date Thu, 02 Jun 2016 14:58:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46158/#review135928
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 97)
<https://reviews.apache.org/r/46158/#comment200942>

    Why make it a static variable? I think `CgroupsIsolatorProcess::create()` will not be
called more than once, right?



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 105 - 106)
<https://reviews.apache.org/r/46158/#comment200947>

    Since this is a multiple lines code, I think you need to add a newline after that, please
check the following code as a reference:
    https://github.com/apache/mesos/blob/0.28.1/src/slave/containerizer/mesos/isolators/network/port_mapping.cpp#L285;L288
    And you may need to do this change for all other places like this.
    
    And what about just name this variable as `subsystem`?



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 106)
<https://reviews.apache.org/r/46158/#comment200946>

    I would suggest to use `string::PREFIX` since we are sure `cgroups/` is the prefix.



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 146)
<https://reviews.apache.org/r/46158/#comment200949>

    s/internal/internally/



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 148)
<https://reviews.apache.org/r/46158/#comment200951>

    s/different with/be different from/



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 149)
<https://reviews.apache.org/r/46158/#comment200952>

    s/is belongs to/belongs to/



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 155)
<https://reviews.apache.org/r/46158/#comment200953>

    s/subsystem/Subsystem/


- Qian Zhang


On April 16, 2016, 6:14 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46158/
> -----------------------------------------------------------
> 
> (Updated April 16, 2016, 6:14 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-5041
>     https://issues.apache.org/jira/browse/MESOS-5041
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Completed implementation of the cgroups unified isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46158/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message