mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 48093: Updated comments in authorizer.proto.
Date Tue, 31 May 2016 23:10:28 GMT


> On May 31, 2016, 10:39 p.m., Joerg Schad wrote:
> > include/mesos/authorizer/authorizer.proto, line 58
> > <https://reviews.apache.org/r/48093/diff/1/?file=1402727#file1402727line58>
> >
> >     only if they set an object (e.g., the teardown)

How about this?
```
// Actions named *_WITH_foo may set a foo in `Object.value`
```


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48093/#review135702
-----------------------------------------------------------


On May 31, 2016, 9:15 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48093/
> -----------------------------------------------------------
> 
> (Updated May 31, 2016, 9:15 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, Joerg Schad,
and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated comments in authorizer.proto.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/authorizer.proto 0142476a2f9c905aafd3e41adc9842445c9309e7

> 
> Diff: https://reviews.apache.org/r/48093/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message