mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 47891: Added RUN_TASK authorization action.
Date Tue, 31 May 2016 07:23:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47891/#review135609
-----------------------------------------------------------



Nits & notes. I could fix these before committing, but you still need to fix the `object->set_value(framework->info.user());`
bug.


include/mesos/authorizer/authorizer.proto (line 49)
<https://reviews.apache.org/r/47891/#comment200638>

    General style is to put a `:` after your `TODO(bbannier):`



include/mesos/authorizer/authorizer.proto (lines 53 - 54)
<https://reviews.apache.org/r/47891/#comment200639>

    This can go at the enum-level comment, just before `enum Action {`



include/mesos/authorizer/authorizer.proto (line 64)
<https://reviews.apache.org/r/47891/#comment200641>

    s/or/and/, since Mesos is the one filling in the object, and Mesos will fill in both.
The authorizer module writer can choose to use fields from one, the other, or both.



include/mesos/authorizer/authorizer.proto (line 66)
<https://reviews.apache.org/r/47891/#comment200642>

    s/value/`value`/ to distinguish the field name from the generic word.



include/mesos/authorizer/authorizer.proto (line 67)
<https://reviews.apache.org/r/47891/#comment200643>

    s/Its/This/



include/mesos/authorizer/authorizer.proto (lines 70 - 71)
<https://reviews.apache.org/r/47891/#comment200640>

    Please reverse the order, so the recommended one is listed first.


- Adam B


On May 30, 2016, 6:42 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47891/
> -----------------------------------------------------------
> 
> (Updated May 30, 2016, 6:42 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Michael Park.
> 
> 
> Bugs: MESOS-5459
>     https://issues.apache.org/jira/browse/MESOS-5459
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Authorization requests for RUN_TASK actions can pass `SOME`
> authorization object either in a `FrameworkInfo` holding a user, or a
> `TaskInfo` with optionally a `CommandInfo` which can optionally hold a
> user. If either of these fields is set it will be used as the object;
> otherwise an `ANY` type authorization object will be created.
> 
> `RUN_TASK` aliases `RUN_TASK_WITH_USER` which becomes deprecated with
> 0.29.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/authorizer.proto 4478bbd3c8f5c1fb862c2c6bd450689d870f7059

>   src/authorizer/local/authorizer.cpp 547bbdd6c3605eadd23d2d2717a3fd362a616de5 
>   src/master/master.cpp a6f740f7f71c4b54208e923025d32e0473a65f5e 
>   src/tests/authorization_tests.cpp 54bfb46a807677f4a4a2bb88dcb78a358cf5121a 
> 
> Diff: https://reviews.apache.org/r/47891/diff/
> 
> 
> Testing
> -------
> 
> Tested on a range of Linux configurations on internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message