mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 46093: Enhanced the error message for invalid duration unit.
Date Mon, 30 May 2016 22:44:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46093/#review135551
-----------------------------------------------------------


Fix it, then Ship it!




I'll fix the issue and commit it for you.


3rdparty/stout/include/stout/duration.hpp (lines 70 - 72)
<https://reviews.apache.org/r/46093/#comment200580>

    How about 
    ```
            return Error(
                "Unknown duration unit '" + unit + "'; supported units are"
                " 'ns', 'us', 'ms', 'secs', 'mins', 'hrs', 'days', and 'weeks'");
    ```


- Alexander Rukletsov


On May 23, 2016, 3:41 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46093/
> -----------------------------------------------------------
> 
> (Updated May 23, 2016, 3:41 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-5179
>     https://issues.apache.org/jira/browse/MESOS-5179
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enhanced the error message for invalid duration unit.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/duration.hpp aea280830731a0e8c1aacd3fb6aef27291cc6f0b

> 
> Diff: https://reviews.apache.org/r/46093/diff/
> 
> 
> Testing
> -------
> 
> LiuGuangyas-MacBook-Pro:build gyliu$ ./bin/mesos-master.sh --offer_timeout=4cc
> Failed to load flag 'offer_timeout': Failed to load value '4cc': Unknown duration unit
'cc', the supported units are 'ns', 'us', 'ms', 'secs', 'mins', 'hrs', 'days' and 'weeks'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message