mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 47987: Constrained constructible types constructor for `Result`.
Date Mon, 30 May 2016 06:32:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47987/#review135466
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On May 29, 2016, 9:05 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47987/
> -----------------------------------------------------------
> 
> (Updated May 29, 2016, 9:05 a.m.)
> 
> 
> Review request for mesos, Michael Park and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This ensures that `Result` can only be created from constructible
> types. This logic is similar to the one already present in `Option`. 
> Somehow, this constaint was never added for `Result`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/result.hpp 5d93ee03248249117f8ce259ebb1b126803e1a5c 
> 
> Diff: https://reviews.apache.org/r/47987/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message